Skip to content

Fix compatibility with zeroconf 0.27#263

Merged
ikalchev merged 1 commit into
ikalchev:devfrom
bdraco:zeroconf_027_compat
May 30, 2020
Merged

Fix compatibility with zeroconf 0.27#263
ikalchev merged 1 commit into
ikalchev:devfrom
bdraco:zeroconf_027_compat

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented May 29, 2020

Fixes #262

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #263 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #263   +/-   ##
=======================================
  Coverage   64.45%   64.45%           
=======================================
  Files          16       16           
  Lines        1761     1761           
  Branches      189      189           
=======================================
  Hits         1135     1135           
  Misses        573      573           
  Partials       53       53
Impacted Files Coverage Δ
pyhap/accessory_driver.py 70.06% <ø> (ø)

@bdraco bdraco mentioned this pull request May 29, 2020
Merged
27 tasks
@ikalchev ikalchev merged commit c6ff354 into ikalchev:dev May 30, 2020
@ikalchev
Copy link
Copy Markdown
Owner

ikalchev commented May 30, 2020

Should we also update requirements.txt to require zaeroconf >=0.27?

elupus
elupus reviewed May 30, 2020
View reviewed changes
Copy link
Copy Markdown

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array returned from getaddrinfo should probably have been used.

@elupus
Copy link
Copy Markdown

elupus commented May 30, 2020

Then again, the lib doesn't do that for it's tests. So..

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented May 30, 2020

Should we also update requirements.txt to require zaeroconf >=0.27?

It should work with both newer and older versions due to the keyword args being added. Sadly we are going to need another release sometime soon to unblock Home Assistant from upgrading.

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented May 30, 2020 •
edited
Loading

Verified with busy home that both zeroconf 0.26.3 and 0.27.0 work with the change

@ikalchev
Copy link
Copy Markdown
Owner

ikalchev commented May 31, 2020

Will release later today

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented May 31, 2020

Will release later today

Thanks. 2.9.0 has been going great, no more cpu spikes or unexpected reconnects after running it since you published.

@ikalchev
Copy link
Copy Markdown
Owner

ikalchev commented May 31, 2020

2.9.1 is now GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elupus elupus elupus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Two exceptions raised while driver starts up

4 participants

@bdraco @codecov-commenter @ikalchev @elupus